This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Add build_unary_op, use it instead of stabilize_expr for various unary ops #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
changed the title
ibuclaw
force-pushed
the
complexunary
branch
2 times, most recently
from
29fb636
to
eb9c8d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion in #640,
stabilize_exprshould be repurposed into two kinds of functions. The first that applies operations on complex/compound lvalue expressions, the second that removes all side effects from an expression and returns a single lvalue.This is the first, will move other helper functions over to this in steps to make sure nothing gets broken.