Implement -verrors and suport @file better.
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `@FILE` arguments are passed, read the whole file not just the first line like the current implementation. Drop the requirement that `@...` arguments have to end in `.rsp`. This is consistent with dmd and used out in the wild by dub which uses `@...rsp` when building and `@...lnk` when linking. To account for this the matching code has been moved up the if .. elsif block. The implementation was also changed to use a local file handle instead of the legacy bareword and the two-argument form of open has been replaced by the three-argument one. Add a space in the help string to compensate for the `\@` escape. When a string argument ends in a number of `\`, half their number instead of dropping it to one, this is the same as dmd. It is unlikely that this will ever come up so it is only for completeness. Specifically `"a \\\\"` gets converted to `a \` when dmd converts it to `a \\`. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
|
@ibuclaw I think the PR looks good, can we get it merged? |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@FILEfixes would make gdmd usable with dub.The unimplemented
-verrorsswitch I've hit in dlang-community/DCD#774.