Merge pull request #746 from yebblies/issue5554

Issue 5554 - [qtd] Covariance detection failure
dlang · Feb 21, 2012 · 027fdbc · 027fdbc
2 parents 907c94d + ca61268
commit 027fdbc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/func.c b/src/func.c
@@ -609,9 +609,14 @@ void FuncDeclaration::semantic(Scope *sc)
                     }
                     if (ti)
                     {
-                        if (tintro && !tintro->equals(ti))
+                        if (tintro)
                         {
-                            error("incompatible covariant types %s and %s", tintro->toChars(), ti->toChars());
+                            if (!tintro->nextOf()->equals(ti->nextOf()) &&
+                                !tintro->nextOf()->isBaseOf(ti->nextOf(), NULL) &&
+                                !ti->nextOf()->isBaseOf(tintro->nextOf(), NULL))
+                            {
+                                error("incompatible covariant types %s and %s", tintro->toChars(), ti->toChars());
+                            }
                         }
                         tintro = ti;
                     }

diff --git a/test/runnable/xtest46.d b/test/runnable/xtest46.d
@@ -3383,6 +3383,26 @@ ref func2521_7() {
     return val;
 }
 
+/***************************************************/
+
+void test5554()
+{
+    class MA { }
+    class MB : MA { }
+    class MC : MB { }
+
+    class A { abstract MA foo(); }
+    interface I { MB foo(); }
+    class B : A
+    {
+        MC foo() { return null; }
+    }
+    class C : B, I
+    {
+        override MC foo() { return null; }
+    }
+}
+
 /***************************************************/
 // 5962
 
@@ -4730,6 +4750,7 @@ int main()
     test85();
     test86();
     test87();
+    test5554();
     test88();
     test7545();
     test89();