Merge pull request #353 from yebblies/issue3581

Issue 3581 - "private" attribute breaks "override"
dlang · Aug 31, 2011 · 07fccae · 07fccae
2 parents ba4da91 + 76e3230
commit 07fccae
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/src/func.c b/src/func.c
@@ -274,6 +274,9 @@ void FuncDeclaration::semantic(Scope *sc)
     if (isAbstract() && !isVirtual())
         error("non-virtual functions cannot be abstract");
 
+    if (isOverride() && !isVirtual())
+        error("cannot override a non-virtual function");
+
     if ((f->isConst() || f->isImmutable()) && !isThis())
         error("without 'this' cannot be const/immutable");
 

diff --git a/test/fail_compilation/fail3581a.d b/test/fail_compilation/fail3581a.d
@@ -0,0 +1,5 @@
+
+class A { void f() {} }
+class B : A { static override void f() {}; }
+
+void main() {}
diff --git a/test/fail_compilation/fail3581b.d b/test/fail_compilation/fail3581b.d
@@ -0,0 +1,5 @@
+
+class A { void f() {} }
+class B : A { private override void f() {}; }
+
+void main() {}