Skip to content

Commit

Permalink
Add "FIXME" comment for issue 10604 in ScopeDsymbol::search
Browse files Browse the repository at this point in the history
  • Loading branch information
9rnsr committed Mar 14, 2014
1 parent cad1dfd commit 5b7e797
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/dsymbol.c
Expand Up @@ -899,7 +899,8 @@ Dsymbol *ScopeDsymbol::search(Loc loc, Identifier *ident, int flags)
{
//printf("\ts = '%s.%s', prot = %d\n", toChars(), s1->toChars(), s1->prot());
// The found symbol which has private access should be invisible
if ((flags & IgnorePrivateMembers) && !s1->isOverloadable() && s1->prot() == PROTprivate)
// FIXME: Issue 10604 - Not consistent access check for overloaded symbols
if ((flags & IgnorePrivateMembers) && /*!s1->isOverloadable() && */s1->prot() == PROTprivate)
s1 = NULL;
return s1;
}
Expand Down Expand Up @@ -1006,7 +1007,8 @@ Dsymbol *ScopeDsymbol::search(Loc loc, Identifier *ident, int flags)
s = a;
}

if (!(flags & IgnoreErrors) && !s->isOverloadable() &&
// FIXME: Issue 10604 - Not consistent access check for overloaded symbols
if (!(flags & IgnoreErrors) /*&& !s->isOverloadable()*/ &&
s->prot() == PROTprivate && !s->parent->isTemplateMixin())
{
if (!s->isImport())
Expand Down

0 comments on commit 5b7e797

Please sign in to comment.