Merge pull request #3912 from yebblies/issue3990

Issue 3990 - Deferencing a dynamic array as pointer

src/expression.c

@@ -9185,7 +9185,7 @@ Expression *PtrExp::semantic(Scope *sc)
 
         case Tsarray:
         case Tarray:
-            deprecation("using * on an array is deprecated; use *(%s).ptr instead", e1->toChars());
+            error("using * on an array is no longer supported; use *(%s).ptr instead", e1->toChars());
             type = ((TypeArray *)tb)->next;
             e1 = e1->castTo(sc, type->pointerTo());
             break;

test/fail_compilation/fail3990.d

@@ -0,0 +1,15 @@
+/*
+TEST_OUTPUT:
+---
+fail_compilation/fail3990.d(12): Error: using * on an array is no longer supported; use *(arr1).ptr instead
+fail_compilation/fail3990.d(14): Error: using * on an array is no longer supported; use *(arr2).ptr instead
+---
+*/
+
+void main()
+{
+    int[] arr1 = [1, 2, 3];
+    assert(*arr1 == 1);
+    int[3] arr2 = [1, 2, 3];
+    assert(*arr2 == 1);
+}

test/runnable/deprecate1.d

@@ -1224,22 +1224,6 @@ void test4237()
     foo4237(); bar4237();
 }
 
-/******************************************/
-// 3990
-
-void test3990()
-{
-    int[] a1 = [5, 4, 3];
-    assert(*a1 == 5);
-    alias typeof(a1) T1;
-    assert(is(typeof(*T1)));
-
-    int[3] a2 = [5, 4, 3];
-    assert(*a2 == 5);
-    alias typeof(a2) T2;
-    assert(is(typeof(*T2)));
-}
-
 /******************************************/
 // from extra-files/test2.d
 
@@ -1311,7 +1295,6 @@ int main()
     test23_test67();
     test34_test14();
     test34_test52();
-    test3990();
     test6289();
     test4237();
     test18();