Fix Issue 12598 - Emit better diagnostics when type is found where an…

… lvalue was expected.
dlang · Apr 19, 2014 · 776cc73 · 776cc73
1 parent 05e3f24
commit 776cc73
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/src/expression.c b/src/expression.c
@@ -2102,7 +2102,12 @@ Expression *Expression::toLvalue(Scope *sc, Expression *e)
         e = this;
     else if (!loc.filename)
         loc = e->loc;
-    error("%s is not an lvalue", e->toChars());
+
+    if (e->op == TOKtype)
+        error("%s '%s' is a type, not an lvalue", e->type->kind(), e->type->toChars());
+    else
+        error("%s is not an lvalue", e->toChars());
+
     return new ErrorExp();
 }
 

diff --git a/test/fail_compilation/diag12598.d b/test/fail_compilation/diag12598.d
@@ -0,0 +1,21 @@
+/*
+TEST_OUTPUT:
+---
+fail_compilation/diag12598.d(13): Error: struct 'lines' is a type, not an lvalue
+---
+*/
+
+class C
+{
+    void f()
+    {
+        import imports.diag12598a;
+        lines ~= "";
+    }
+
+    string[] lines;
+}
+
+void main()
+{
+}
diff --git a/test/fail_compilation/imports/diag12598a.d b/test/fail_compilation/imports/diag12598a.d
@@ -0,0 +1,3 @@
+module imports.diag12598a;
+
+struct lines { }