fix Issue 14806 - alias this doesn't force elaborate equality, but is…

… followed during it
dlang · Jul 19, 2015 · 83fa6ac · 83fa6ac
1 parent 84294e1
commit 83fa6ac
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/clone.c b/src/clone.c
@@ -368,6 +368,8 @@ bool needOpEquals(StructDeclaration *sd)
             TypeStruct *ts = (TypeStruct *)tv;
             if (needOpEquals(ts->sym))
                 goto Lneed;
+            if (ts->sym->aliasthis)     // Bugzilla 14806
+                goto Lneed;
         }
     }
 Ldontneed:

diff --git a/test/runnable/aliasthis.d b/test/runnable/aliasthis.d
@@ -1674,7 +1674,10 @@ struct RefCounted12008(T)
         return 0;
     }
 
-    int refCountedPayload() inout;
+    int refCountedPayload() inout
+    {
+        return 0;
+    }
 
     alias refCountedPayload this;
 }
@@ -1802,6 +1805,34 @@ void test13009()
     alias ISput  = IS .put;
 }
 
+/***************************************************/
+// 14806
+
+struct Nullable14806
+{
+    float get() { return float.nan; }
+    alias get this;
+}
+
+struct Foo14806(T)
+{
+    T bar;
+    Nullable14806 baz;
+}
+
+void test14806()
+{
+    Foo14806!int a, b;
+    assert(a != b);
+    // ==> a.tupleof != b.tupleof
+    // ==> a.bar != b.bar || a.baz.get() != b.baz.get()
+
+    Foo14806!string c, d;
+    assert(c != d);
+    // ==> c.tupleof != d.tupleof
+    // ==> c.bar != d.bar || c.baz.get() != d.baz.get()
+}
+
 /***************************************************/
 
 int main()
@@ -1857,6 +1888,7 @@ int main()
     test11800();
     test13490();
     test11355();
+    test14806();
 
     printf("Success\n");
     return 0;