Merge pull request #3287 from schuetzm/non_final_switch_hint

Give users some guidance on how to handle missing default cases.
dlang · Feb 22, 2014 · 88d52ff · 88d52ff
2 parents 091df98 + c5857b7
commit 88d52ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/statement.c b/src/statement.c
@@ -2899,7 +2899,7 @@ Statement *SwitchStatement::semantic(Scope *sc)
     {   hasNoDefault = 1;
 
         if (!isFinal && !body->isErrorStatement())
-           deprecation("non-final switch statement without a default is deprecated");
+           deprecation("non-final switch statement without a default is deprecated; add 'default: assert(0);' or 'default: break;'");
 
         // Generate runtime error if the default is hit
         Statements *a = new Statements();

diff --git a/test/fail_compilation/fail287.d b/test/fail_compilation/fail287.d
@@ -2,7 +2,7 @@
 TEST_OUTPUT:
 ---
 fail_compilation/fail287.d(14): Error: had 299 cases which is more than 256 cases in case range
-fail_compilation/fail287.d(12): Deprecation: non-final switch statement without a default is deprecated
+fail_compilation/fail287.d(12): Deprecation: non-final switch statement without a default is deprecated; add 'default: assert(0);' or 'default: break;'
 ---
 */