Skip to content

Commit

Permalink
Consistently use "Internal Compiler Error", rather than "ICE" that is…
Browse files Browse the repository at this point in the history 
… not widely known
  • Loading branch information
@9rnsr
9rnsr committed Dec 1, 2014
1 parent 1fb3ba8 commit 9ed0fd5
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 22 deletions.
4 changes: 2 additions & 2 deletions src/clone.c
View file
Expand Up @@ -502,7 +502,7 @@ FuncDeclaration *buildXopEquals(StructDeclaration *sd, Scope *sc)
Dsymbol *s = getDsymbol(e);
if (!s)
{
::error(Loc(), "ICE: %s not found in object module. You must update druntime", id->toChars());
::error(Loc(), "Internal Compiler Error: %s not found in object module. You must update druntime", id->toChars());
fatal();
}
assert(s);
Expand Down Expand Up @@ -628,7 +628,7 @@ FuncDeclaration *buildXopCmp(StructDeclaration *sd, Scope *sc)
Dsymbol *s = getDsymbol(e);
if (!s)
{
::error(Loc(), "ICE: %s not found in object module. You must update druntime", id->toChars());
::error(Loc(), "Internal Compiler Error: %s not found in object module. You must update druntime", id->toChars());
fatal();
}
assert(s);
Expand Down
34 changes: 17 additions & 17 deletions src/cppmangle.c
View file
Expand Up @@ -175,7 +175,7 @@ class CppMangleVisitor : public Visitor
}
else
{
s->error("ICE: C++ %s template value parameter is not supported", tv->valType->toChars());
s->error("Internal Compiler Error: C++ %s template value parameter is not supported", tv->valType->toChars());
assert(0);
}
}
Expand All @@ -191,7 +191,7 @@ class CppMangleVisitor : public Visitor
Expression *e = isExpression(o);
if (!d && !e)
{
s->error("ICE: %s is unsupported parameter for C++ template: (%s)", o->toChars());
s->error("Internal Compiler Error: %s is unsupported parameter for C++ template: (%s)", o->toChars());
assert(0);
}
if (d && d->isFuncDeclaration())
Expand Down Expand Up @@ -219,14 +219,14 @@ class CppMangleVisitor : public Visitor
}
else
{
s->error("ICE: %s is unsupported parameter for C++ template", o->toChars());
s->error("Internal Compiler Error: %s is unsupported parameter for C++ template", o->toChars());
assert(0);
}

}
else
{
s->error("ICE: C++ templates support only integral value , type parameters, alias templates and alias function parameters");
s->error("Internal Compiler Error: C++ templates support only integral value, type parameters, alias templates and alias function parameters");
assert(0);
}
}
Expand Down Expand Up @@ -399,7 +399,7 @@ class CppMangleVisitor : public Visitor

if (!(d->storage_class & (STCextern | STCgshared)))
{
d->error("ICE: C++ static non- __gshared non-extern variables not supported");
d->error("Internal Compiler Error: C++ static non- __gshared non-extern variables not supported");
assert(0);
}

Expand Down Expand Up @@ -509,7 +509,7 @@ class CppMangleVisitor : public Visitor
if (t->ty == Tsarray)
{
// Mangle static arrays as pointers
t->error(Loc(), "ICE: Unable to pass static array to extern(C++) function.");
t->error(Loc(), "Internal Compiler Error: unable to pass static array to extern(C++) function.");
t->error(Loc(), "Use pointer instead.");
assert(0);
//t = t->nextOf()->pointerTo();
Expand Down Expand Up @@ -567,11 +567,11 @@ class CppMangleVisitor : public Visitor
{
if (t->isImmutable() || t->isShared())
{
t->error(Loc(), "ICE: shared or immutable types can not be mapped to C++ (%s)", t->toChars());
t->error(Loc(), "Internal Compiler Error: shared or immutable types can not be mapped to C++ (%s)", t->toChars());
}
else
{
t->error(Loc(), "ICE: Unsupported type %s\n", t->toChars());
t->error(Loc(), "Internal Compiler Error: unsupported type %s\n", t->toChars());
}
assert(0); //Assert, because this error should be handled in frontend
}
Expand Down Expand Up @@ -938,11 +938,11 @@ class VisualCPPMangler : public Visitor
{
if (type->isImmutable() || type->isShared())
{
type->error(Loc(), "ICE: shared or immutable types can not be mapped to C++ (%s)", type->toChars());
type->error(Loc(), "Internal Compiler Error: shared or immutable types can not be mapped to C++ (%s)", type->toChars());
}
else
{
type->error(Loc(), "ICE: Unsupported type %s\n", type->toChars());
type->error(Loc(), "Internal Compiler Error: unsupported type %s\n", type->toChars());
}
assert(0); // Assert, because this error should be handled in frontend
}
Expand Down Expand Up @@ -1358,7 +1358,7 @@ class VisualCPPMangler : public Visitor
assert(d);
if (!(d->storage_class & (STCextern | STCgshared)))
{
d->error("ICE: C++ static non- __gshared non-extern variables not supported");
d->error("Internal Compiler Error: C++ static non- __gshared non-extern variables not supported");
assert(0);
}
buf.writeByte('?');
Expand Down Expand Up @@ -1490,7 +1490,7 @@ class VisualCPPMangler : public Visitor
}
else
{
sym->error("ICE: C++ %s template value parameter is not supported", tv->valType->toChars());
sym->error("Internal Compiler Error: C++ %s template value parameter is not supported", tv->valType->toChars());
assert(0);
}
}
Expand All @@ -1506,7 +1506,7 @@ class VisualCPPMangler : public Visitor
Expression *e = isExpression(o);
if (!d && !e)
{
sym->error("ICE: %s is unsupported parameter for C++ template", o->toChars());
sym->error("Internal Compiler Error: %s is unsupported parameter for C++ template", o->toChars());
assert(0);
}
if (d && d->isFuncDeclaration())
Expand Down Expand Up @@ -1548,22 +1548,22 @@ class VisualCPPMangler : public Visitor
}
else
{
sym->error("ICE: C++ templates support only integral value , type parameters, alias templates and alias function parameters");
sym->error("Internal Compiler Error: C++ templates support only integral value, type parameters, alias templates and alias function parameters");
assert(0);
}
}
tmp.mangleIdent(d);
}
else
{
sym->error("ICE: %s is unsupported parameter for C++ template: (%s)", o->toChars());
sym->error("Internal Compiler Error: %s is unsupported parameter for C++ template: (%s)", o->toChars());
assert(0);
}

}
else
{
sym->error("ICE: C++ templates support only integral value , type parameters, alias templates and alias function parameters");
sym->error("Internal Compiler Error: C++ templates support only integral value, type parameters, alias templates and alias function parameters");
assert(0);
}
}
Expand Down Expand Up @@ -1860,7 +1860,7 @@ class VisualCPPMangler : public Visitor
}
if (t->ty == Tsarray)
{
t->error(Loc(), "ICE: Unable to pass static array to extern(C++) function.");
t->error(Loc(), "Internal Compiler Error: unable to pass static array to extern(C++) function.");
t->error(Loc(), "Use pointer instead.");
assert(0);
}
Expand Down
4 changes: 2 additions & 2 deletions src/e2ir.c
View file
Expand Up @@ -1660,7 +1660,7 @@ elem *toElem(Expression *e, IRState *irs)
}
else
{
ne->error("ICE: cannot new type %s\n", t->toChars());
ne->error("Internal Compiler Error: cannot new type %s\n", t->toChars());
assert(0);
}

Expand Down Expand Up @@ -2999,7 +2999,7 @@ elem *toElem(Expression *e, IRState *irs)
}
else
{
ce->error("ICE: cannot append '%s' to '%s'", tb2->toChars(), tb1->toChars());
ce->error("Internal Compiler Error: cannot append '%s' to '%s'", tb2->toChars(), tb1->toChars());
assert(0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/interpret.c
View file
Expand Up @@ -2599,7 +2599,7 @@ class Interpreter : public Visitor
continue;
if (ex->op == TOKvoidexp)
{
e->error("ICE: void element %s in tuple", exp->toChars());
e->error("Internal Compiler Error: void element %s in tuple", exp->toChars());
assert(0);
}

Expand Down

0 comments on commit 9ed0fd5

Please sign in to comment.