D2: warn about static array parameters

dlang · Jul 29, 2014 · c4c1c8d · 9rnsr · Jul 29, 2014 · c4c1c8d
1 parent 26912c8
commit c4c1c8d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/mtype.c b/src/mtype.c
@@ -49,6 +49,7 @@
 #include "import.h"
 #include "aggregate.h"
 #include "hdrgen.h"
+#include "module.h"
 
 FuncDeclaration *hasThis(Scope *sc);
 
@@ -2969,6 +2970,7 @@ Type *TypeFunction::semantic(Loc loc, Scope *sc)
             if (tf->inuse == 1) tf->inuse--;
 
             Type *t = fparam->type->toBasetype();
+printf("t = %s\n", t->toChars());
 
             if (fparam->storageClass & (STCout | STCref | STClazy))
             {
@@ -3020,6 +3022,12 @@ Type *TypeFunction::semantic(Loc loc, Scope *sc)
                 i--;
                 continue;
             }
+
+            if (global.params.Dversion >= 3 && sc->module && sc->module->isRoot() &&
+                t->ty == Tsarray)
+            {
+                warning(loc, "D2 passes static arrays by value, use %s[] instead", t->next->toChars());
+            }
         }
         argsc->pop();
     }