fix Issue 13385 - ICE with new package(names) protection

dlang · Aug 28, 2014 · fe707eb · fe707eb
1 parent 1f8280c
commit fe707eb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/attrib.c b/src/attrib.c
@@ -600,11 +600,11 @@ void ProtDeclaration::semantic(Scope* sc)
 
     if ((protection.kind == PROTpackage) && (protection.pkg != NULL) && sc->module)
     {
-        Package* pkg =  sc->module->parent->isPackage();
-        assert(pkg);
-        if (pkg && !protection.pkg->isAncestorPackageOf(pkg))
+        Module *m = sc->module;
+        Package* pkg =  m->parent ? m->parent->isPackage() : NULL;
+        if (!pkg || !protection.pkg->isAncestorPackageOf(pkg))
             error("does not bind to one of ancestor packages of module '%s'",
-               sc->module->toPrettyChars(true));
+               m->toPrettyChars(true));
     }
 }
 

diff --git a/test/fail_compilation/ice13385.d b/test/fail_compilation/ice13385.d
@@ -0,0 +1,9 @@
+/*
+TEST_OUTPUT:
+---
+fail_compilation/ice13385.d(9): Error: protection attribute 'package(a)' does not bind to one of ancestor packages of module 'ice13385'
+---
+*/
+module ice13385;
+
+package(a) void foo() {}