Fix regression introduced by issue 7793 fix. #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3bfac13, inc is set to 2 instead of 0, which causes errors to go by unnoticed in some circumstances. An alternative fix for 7793 would be to only skip invoking e->ctfeInterpret() if the type is not bool – I'm not sure why/if returning early is preferrable here.
WalterBright
added a commit
that referenced
this pull request
Jun 22, 2012
Fix regression introduced by issue 7793 fix.
WalterBright
added a commit
that referenced
this pull request
Jun 25, 2012
WalterBright
added a commit
that referenced
this pull request
Jul 14, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3bfac13, inc is set to 2 instead of 0, which causes errors to go by unnoticed in some circumstances.
An alternative fix for 7793 would be to only skip invoking e->ctfeInterpret() if the type is not bool – I'm not sure why/if returning early is preferrable here.