Issue 7437,7980,8053 - Partial fix for stack overflow with recursive alias this #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1904,6 +1904,9 @@ int typeMerge(Scope *sc, Expression *e, Type **pt, Expression **pe1, Expression | |||
| assert(t1); | |||
| Type *t = t1; | |||
|
|
|||
| Type *att1 = NULL; | |||
There was a problem hiding this comment.
Please, some comments for what these variables represent.
|
Basically, I find the intrusiveness of this a bit intimidating. I hope there's a simpler way. |
|
Add two commits: improve comments, reduce TypeStruct and TypeClass size with packing field, and use enum.
I think this is difficult... |
|
Now, auto tester fails only in Windows platform, and it is reproduced in my PC. |
WalterBright
added a commit
that referenced
this pull request
Mar 7, 2013
Issue 7437,7980,8053 - Partial fix for stack overflow with recursive alias this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 7437 - DMD enters infinite loop during overload resolution
Issue 7980 - Stack overflow / recursive expansion with alias this
Issue 8053 - Recursive alias this causes infinite loop
Compiler should detect recursive alias this dependencies and avoid stack overflow / infinite loop.
This pull request is not complete (there is still problems around CastExp and castTo), but able to detect many cases.