fix Issue 3404 - JSON output should retain original alias names #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "kind" : "variable", | ||
| "protection" : "public", | ||
| "type" : "int", | ||
| "originalType" : "myInt", |
There was a problem hiding this comment.
I would expect that an alias is the type, and the type which was aliased is the original type, not the other way around.
Better yet, why not just rename this to aliasType? It won't be ambiguous then.
There was a problem hiding this comment.
enums and typedefs can also change the type from the "originalType" (even though typedefs are deprecated). originalType is essentially what is in the user source code before semantic analysis.
There was a problem hiding this comment.
Ok, but I hope this will be documented somewhere. In fact, is JSON output documented at all?
WalterBright
added a commit
that referenced
this pull request
Jan 20, 2013
fix Issue 3404 - JSON output should retain original alias names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=3404
Trying to break #1179 into manageable chunks.