Issue 10421 - 'package' access should work with package module #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!pkg || pkg->isPkgMod != PKGmodule) | ||
| continue; | ||
| assert(pkg->mod == m); | ||
| s = pkg; |
There was a problem hiding this comment.
And break, because we know pkg is a package?
|
@yebblies Sorry I found another inaccessible case after opening this. So I updated commit to fix it. Could you please review this again? |
|
LGTM I'll wait for the tester to catch up. |
|
Ugh, I found third inaccessible case in local... Please wait merging a moment. |
|
OK... finally there's three package access cases, and right now #2229 is necessary for the third case. |
|
So this one now includes #2229 ? |
|
Yes. Merging this would automatically merge #2229 at the same time. |
yebblies
added a commit
that referenced
this pull request
Jun 20, 2013
Issue 10421 - 'package' access should work with package module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10421