[REG2.064a] fix issue 10612 - ICE on using enum as hash key with mutual module imports #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7272,7 +7274,7 @@ Type *TypeEnum::syntaxCopy() | |||
| Type *TypeEnum::semantic(Loc loc, Scope *sc) | |||
| { | |||
| //printf("TypeEnum::semantic() %s\n", toChars()); | |||
| //sym->semantic(sc); | |||
| sym->semantic(sc); | |||
There was a problem hiding this comment.
I'm actually not sure about this. Isn't this the wrong scope?
There was a problem hiding this comment.
To resolve forward reference, each Dsymbols have scope field (it's set by Dsymbol::setScope).
And also, EnumDeclaration has isdone field to avoid multiple semantic call. So here should be:
Type *TypeEnum::semantic(Loc loc, Scope *sc)
{
//printf("TypeEnum::semantic() %s\n", toChars());
if (!sym->isdone)
{
assert(sym->scope);
sym->semantic(sym->scope);
}
return merge();
}
| @@ -247,6 +247,15 @@ void test10561() | |||
| } | |||
|
|
|||
| /**********************************************/ | |||
| // 10612 | |||
There was a problem hiding this comment.
Ouch, so it's not even an import dependency issue. I guess the bug title should be renamed. :)
|
LGTM. |
9rnsr
added a commit
that referenced
this pull request
Jul 13, 2013
[REG2.064a] fix issue 10612 - ICE on using enum as hash key with mutual module imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10612