10452 CTFE: Cannot compare delegates with == or 'is' #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -616,6 +616,7 @@ Expression *getAggregateFromPointer(Expression *e, dinteger_t *ofs) | |||
| assert(v); | |||
| StructLiteralExp *se = ex->op == TOKclassreference ? ((ClassReferenceExp *)ex)->value : (StructLiteralExp *)ex; | |||
| // We can't use getField, because it makes a copy | |||
| assert(se->elements); | |||
added 2 commits
July 19, 2013 18:40
&expr.func needs to work for arbitrary expr, not just VarExp. Tighten the CTFE sanity checks.
Support == and 'is' for delegates.
WalterBright
added a commit
that referenced
this pull request
Jul 21, 2013
10452 CTFE: Cannot compare delegates with == or 'is'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10452
Delegate expressions weren't being interpreted properly. And delegate comparison wasn't implemented at all.
The tests here cover many more cases than are in the original bug report.