[enh] Issue 10818 - Allow parameterized enum declaration #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -459,6 +460,8 @@ Dsymbols *Parser::parseDeclDefs(int once, Dsymbol **pLastDecl) | |||
| break; | |||
| } | |||
|
|
|||
| Token *tk; | |||
There was a problem hiding this comment.
Not sure why you've moved this up, it's only used below.
There was a problem hiding this comment.
There's no big reason.
- The original place was slightly difficult to find the declaration statement.
- The code block
Look for auto initializers:might usetkvariable in the future (eg. DIP32)
|
Can this be closed? IIUC the functionality has been implemented by PR #2467. |
|
@9rnsr: Update on the last comment? |
|
DIP42 was for manifest constant declaration syntax, but issue 10810 is a small syntactic sugar for normal enum declarations. But, today this is very low priority and nobody interests it. So I close this, but anyone can reopen to discuss the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10818