Issue 9107 - Value Range Analysis with uint and byte #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| IntRange targetUnsigned = IntRange::fromType(t, /*isUnsigned*/true) DUMP; | ||
| IntRange targetSigned = IntRange::fromType(t, /*isUnsigned*/false) DUMP; | ||
| if (targetUnsigned.contains(src) || targetSigned.contains(src)) | ||
| IntRange target = IntRange::fromType(t) DUMP; |
There was a problem hiding this comment.
This change makes me nervous. I know it passes the test suite, but what code will this break, now that it is no longer relaxed about signed/unsigned?
There was a problem hiding this comment.
what code will this break
Code that was wrong.
There was a problem hiding this comment.
guess I asked for that :-)
There was a problem hiding this comment.
Guess we'll see what breaks!
WalterBright
added a commit
that referenced
this pull request
Nov 25, 2013
Issue 9107 - Value Range Analysis with uint and byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=9107