Issue 8848 - Array literals and AA literals are rejected as template value parameters #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking pretty green! |
|
Nice. This will be worthy of a changelog entry later. |
| @@ -2508,6 +2508,10 @@ void test9977() | |||
| } | |||
|
|
|||
| /******************************************/ | |||
|
|
|||
| template T8848(int[] a, int[int] b, void* c) {} | |||
|
|
|||
There was a problem hiding this comment.
Needs an attempt to instantiate the template, and use the instantiation to verify it is working as expected. Parsing it successfully is not enough.
There was a problem hiding this comment.
Ok, although it was enough for the fail_compilation test.
…ate value parameters
|
Added some tests. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2014
Issue 8848 - Array literals and AA literals are rejected as template value parameters
ghost
merged commit
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is unnecessary as pretty much everything can be passed, and expressions that can't will be detected when they are interpreted.
https://d.puremagic.com/issues/show_bug.cgi?id=8848