Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10635 - Error: cannot use array to initialize S #2882

Merged
merged 1 commit into from Nov 26, 2013

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Nov 26, 2013

@yebblies
Copy link
Member

Does this affect any of the test cases in https://d.puremagic.com/issues/show_bug.cgi?id=8557#c10 ?

@9rnsr
Copy link
Contributor Author

9rnsr commented Nov 26, 2013

This PR does not change ArrayInitializer::isAssociativeArray(), so I think this PR should not affect it.

And I found some regressions by using your test case, so fixed them.

@yebblies
Copy link
Member

My plan is to get rid of toAssociativeArrayLiteral and pass the type to toExpression when known, so the conditions you added/moved will likely get merged together. But I haven't gotten around to that yet, and these additional test cases will help. LGTM.

@yebblies
Copy link
Member

Auto-merge toggled on

yebblies added a commit that referenced this pull request Nov 26, 2013
Issue 10635 - Error: cannot use array to initialize S
@yebblies yebblies merged commit 9b6e0c4 into dlang:master Nov 26, 2013
@9rnsr 9rnsr deleted the fix10635 branch November 26, 2013 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants