Issue 11982 - ICE(func.c) With function literal with no body #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nextToken(); | ||
| else if (literal) | ||
| error("missing { ... }"); | ||
| if (!literal) |
There was a problem hiding this comment.
Replace if (!literal) with else
There was a problem hiding this comment.
No. Because the semicolon token after the function literal should not be consumed always.
|
missing test case |
|
Updated to fix reviewed points. |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Jan 25, 2014
Issue 11982 - ICE(func.c) With function literal with no body
|
@AndrewEdwards I would recommend this for the release branch, as it is an ICE and fairly non-intrusive patch. |
|
This has been picked because the release is delayed because of issues encountered while building the Windows binaries. |
yebblies
added a commit
that referenced
this pull request
Jan 28, 2014
Issue 11982 - ICE(func.c) With function literal with no body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=11982