[cleanup] Clean up the way strings are created from OutBuffer
#3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +62,7 @@ struct OutBuffer | |||
| void spread(size_t offset, size_t nbytes); | |||
| size_t insert(size_t offset, const void *data, size_t nbytes); | |||
| void remove(size_t offset, size_t nbytes); | |||
| char *toChars(); | |||
| char *peekString(); | |||
There was a problem hiding this comment.
Doc comment, please? ;)
(Just what you also explained in the pull request description.)
|
LGTM, just add doc comments in the function declarations. |
…d confusion with Object::toChars
|
Updated. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Jan 26, 2014
[cleanup] Clean up the way strings are created from `OutBuffer`
ghost
merged commit
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractStringwhich appends a'\0'if necessary then takes ownership of the datatoCharswithpeekStringwhich appends a'\0'if necessary then returns a reference to the internal bufferwritebytewhich is just a less-popular alias ofwriteBytetoCharsis especially nasty in that it does not return a unique heap-backed string unlikeObject::toChars.See also: https://d.puremagic.com/issues/show_bug.cgi?id=9421
@AndrejMitrovic