[DDMD] [refactor] Move inlineScan into a visitor class in inline.c #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2014
| public: | ||
| FuncDeclaration *parent; // function being scanned | ||
| Statement *result; | ||
| Expression *eresult; |
There was a problem hiding this comment.
Can you document these two fields? I haven't kept up to date with the whole visitor introduction to DMD.
There was a problem hiding this comment.
Because visit can't return anything, these are temp variables to bounce the result through. I'll put that in a comment.
|
LGTM other than my comments. |
| return e; | ||
| } | ||
|
|
||
| void UnitTestDeclaration::inlineScan() |
There was a problem hiding this comment.
It came from here - no semantics change.
|
Updated. |
|
I'd hit the automerge button but I can't until the tester starts. There should be an option to schedule an automerge rather than have to randomly check when the tester starts running. :> |
|
Hmm, the tester does seem a little troubled today. |
|
Autotester is back up. |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Feb 2, 2014
[DDMD] [refactor] Move inlineScan into a visitor class in inline.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.