Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12203 - typeof(null) does not convert to "void delegate(float)" #3294

Merged
merged 1 commit into from Feb 20, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Feb 20, 2014

@@ -4224,6 +4224,9 @@ elem *toElem(Expression *e, IRState *irs)
case X(Tnull, Tarray):
case X(Tnull, Taarray):
goto Lzero;
case X(Tnull, Tdelegate):
result = el_long(totym(t), 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just goto Lzero; and merge this with the above cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Fixed.

@yebblies
Copy link
Member

LGTM

@WalterBright
Copy link
Member

Auto-merge toggled on

WalterBright added a commit that referenced this pull request Feb 20, 2014
Issue 12203 - typeof(null) does not convert to "void delegate(float)"
@WalterBright WalterBright merged commit d898c7f into dlang:master Feb 20, 2014
@9rnsr 9rnsr deleted the fix12203 branch February 21, 2014 02:12
ibuclaw pushed a commit to ibuclaw/dmd that referenced this pull request Jul 10, 2022
Reduce LDC diff a bit
merged-on-behalf-of: Iain Buclaw <ibuclaw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants