Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12242 - conflict error with public imports #3388

Merged
merged 2 commits into from Jul 29, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Mar 18, 2014

@WalterBright
Copy link
Member

I don't think this is a compiler bug, see my comment in 12242. Furthermore, I don't understand what new resolution rules this PR introduces.

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 23, 2014

This is a compiler bug on cross-module overload set handling. See my comment in bugzilla.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 7, 2014

@WalterBright In D, overload set cannot contain other overload set. If multiple overload set are imported, they should be merged and flatten to a new set of overloads.

@AndrewEdwards
Copy link
Contributor

@WalterBright , @9rnsr This has been sitting for 4 months without any forward progress. If it is not a bug, mark issue 12242 invalid, close the pull and end the discussion. If it is a bug, merge the fix and move on. Either way, a decision needs to be made.

@AndrewEdwards
Copy link
Contributor

Ping @WalterBright @9rnsr

@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 27, 2014

As I already said, the issue is a compiler bug.

@andralex @yebblies @MartinNowak @AndrejMitrovic How do you think about the issue with D module?

@yebblies
Copy link
Member

The concept seems right to me.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 29, 2014

The concept seems right to me.

Thanks for your opinion.

@WalterBright Please reconsider the issue. I wrote a comment against your argue in bugzilla

@AndrewEdwards
Copy link
Contributor

Unbelievable!

AndrewEdwards added a commit that referenced this pull request Jul 29, 2014
Issue 12242 - conflict error with public imports
@AndrewEdwards AndrewEdwards merged commit 79a406d into dlang:master Jul 29, 2014
9rnsr pushed a commit to 9rnsr/dmd that referenced this pull request Jul 29, 2014
Issue 12242 - conflict error with public imports
@9rnsr 9rnsr deleted the fix12242 branch July 29, 2014 23:48
@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 30, 2014

In bugzilla, @MartinNowak also agrees about the concept.

And thanks for the merging, @AndrewEdwards .

ibuclaw pushed a commit to ibuclaw/dmd that referenced this pull request Jul 10, 2022
merge stable
merged-on-behalf-of: Florian <moonlightsentinel@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants