Revert "Merge pull request #2256 from 9rnsr/fix_imports" #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
This reverts most of commit 6cf3992
|
Auto-merge toggled off |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Mar 21, 2014
Revert "Merge pull request #2256 from 9rnsr/fix_imports"
|
Yes. |
|
Thanks, guys! |
|
Could the test cases for the reported regressions be added to the test suite, so that future attempts don't run into the same regressions? |
|
Most of reported regressions were about the intended changes in #2256, so test case is not necessary. |
|
I thought it was common practice to add test cases for regressions reported for reverted pulls. If anything, then they indicate holes in the test suite coverage, and since the test cases have been formulated already it'd seem wasteful to not add them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts most of commit 6cf3992