[REG2.066a] Issue 12574 - [ICE](statement.c, line 713) with reduce with wrong tuple arity #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (e->op != TOKdotvar) | ||
| return true; | ||
|
|
||
| /* Template instantiations involving a DotVar expression are difficult. |
There was a problem hiding this comment.
No, because it was between two TemplateInstance::semanticTiargss.
… tuple arity Make `TemplateInstance::semanticTiargs` reentrant against semantic errors.
…t + alias this
Make AssignExp::semantic reentrant for `op_overload` call.
-----
If an expression supports operator overloading, its `semantic` function should not store error expressions in itself until the point of `op_olverload` call (from [a] to [b]).
Example:
Expression *XXXExp::semantic(Scope sc)
{
// [a]
...
e1 = e1->semantic(sc); // Bad: if semantic analysis returns ErrorExp,
// it is stored in this->e1 immediately.
if (e1->op == TOKerror)
return e1;
// [b]
Expression *e = op_overload(sc);
if (e)
return e;
...
}
If `XXXExp::semantic` is called from the `trySemantic` call for `alias this` analysis (from `op_overload` function in `opover.c`), the stored ErrorExp would accidentally escape from the gagged period.
|
Add fix for issue 12581. |
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Apr 15, 2014
[REG2.066a] Issue 12574 - [ICE](statement.c, line 713) with reduce with wrong tuple arity
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=12574
It's caused by wrong ErrorExp escaping from gagged period. I'm planning to make
Expression::trySemanticmore robust, but at least this is enough to fix the issue.