Issue 8101 - Fixup pull improving diagnostics when there are overloads present. #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added a commit
that referenced
this pull request
May 2, 2014
Issue 8101 - Fixup pull improving diagnostics when there are overloads present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fixup for the diagnostic introduced in #3508.
https://issues.dlang.org/show_bug.cgi?id=8101
Essentially we don't have to print the argument types of a single function when there are multiple overloads listed.
Another future improvement that could be done is to detect
@propertyfunctions. If the only overloads are properties then the diagnostic could reflect that.