Issue 9570 - Wrong foreach index implicit conversion error #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| range = *vd->range; | ||
| } | ||
| else | ||
| visit((Expression*)e); |
| @@ -2605,6 +2617,12 @@ Statement *ForeachRangeStatement::semantic(Scope *sc) | |||
| ExpInitializer *ie = new ExpInitializer(loc, (op == TOKforeach) ? lwr : upr); | |||
| key = new VarDeclaration(loc, upr->type->mutableOf(), Lexer::uniqueId("__key"), ie); | |||
| key->storage_class |= STCtemp; | |||
| SignExtendedNumber l = getIntRange(lwr).imin; | |||
There was a problem hiding this comment.
Don't use variables named 'l', as they are too easily confused with '1'.
|
@yebblies @WalterBright all is well :) |
WalterBright
added a commit
that referenced
this pull request
Jun 15, 2014
Issue 9570 - Wrong foreach index implicit conversion error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to fix bug 9570.
Added a IntRange* to VarDeclaration which tracks the range for variables for which the range is known, in this case foreach over range, array and sarray. This range will only be used when the iterator is declared const or immutable.
Added a simple test case, based on bug report. This PR is also needed to fix bug 259 (prevent false positives.)