Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12909 & 12910 - fix purity level calculation for AA parameter #3667

Merged
merged 4 commits into from Jun 14, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jun 14, 2014

Issue 12909 - [AA] Function is incorrectly inferred as strongly pure for associative array with key of non-mutable array or pointer as argument
Issue 12910 - [AA] rehash is incorrectly inferred as strongly pure for some associative arrays

@dnadlinger
Copy link
Member

Auto-merge toggled on

dnadlinger added a commit that referenced this pull request Jun 14, 2014
Issue 12909 & 12910 - fix purity level calculation for AA parameter
@dnadlinger dnadlinger merged commit 27fc066 into dlang:master Jun 14, 2014
@9rnsr 9rnsr deleted the fix12909 branch June 14, 2014 15:44
@9rnsr
Copy link
Contributor Author

9rnsr commented Jun 14, 2014

Thanks.

@dnadlinger
Copy link
Member

Given your Phobos changes, it seems that strong purity detection is more aggressive now? This might warrant an explanation in the release notes so that users don't mistake this for a regression.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jun 14, 2014

The purityLevel function has had bugs about the calculation, and enhancement 3882 had highlighted the bug. But fortunately, 3882 is implemented from 2.066 head. So, some behavior changes with -w switch can be documented as an enhancement of warning switch from 2.055.

ibuclaw pushed a commit to ibuclaw/dmd that referenced this pull request Jul 10, 2022
…-unittest

Don't link & run unittests for Win32 + OMF due to OPTLINK issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants