Issue 12902 & 10904 - fix ICEs with opDollar and multidimensional operator overloading #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion.c' when using `opDollar`
… using `opDollar`
| @@ -10986,6 +10986,10 @@ Expression *AssignExp::semantic(Scope *sc) | |||
| if (ex->op == TOKerror) | |||
| return ex; | |||
|
|
|||
| e2 = e2->semantic(sc); | |||
| if (e2->op == TOKerror) | |||
| return e2; | |||
There was a problem hiding this comment.
Currently if the e2 semantic analysis is done under error gagging as an argument of opIndexAssign call, the result would lost. By this change, the semantic result of e2 will be properly taken over to the opSliceAssign call.
WalterBright
added a commit
that referenced
this pull request
Jun 15, 2014
Issue 12902 & 10904 - fix ICEs with opDollar and multidimensional operator overloading
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 12902 - [ICE] Assertion failure '!ae->lengthVar' in 'expression.c' when using
opDollarIssue 12904 - Wrong-code for some slice to slice assignments when using
opDollar