New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 12965 - DMD sets ELFOSABI to ELFOSABI_LINUX on all systems #3687
Conversation
Added bugzilla link to the original message. |
@@ -1069,7 +1081,7 @@ void Obj::term(const char *objfilename) | |||
ELFCLASS32, // EI_CLASS | |||
ELFDATA2LSB, // EI_DATA | |||
EV_CURRENT, // EI_VERSION | |||
ELFOSABI_LINUX,0, // EI_OSABI,EI_ABIVERSION | |||
ELFOSABI,0, // EI_OSABI,EI_ABIVERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align comments.
Added the requested tweaks. |
Fix issue 12965 - DMD sets ELFOSABI to ELFOSABI_LINUX on all systems
This pull broke dmd build on my LInux/64-bit machine:
|
Looks like it's missing an |
Fix: pull #3691 |
Eek! I had fixed this locally and thought I had pushed this out along with the other requested changes, but apparently did not. Sorry :( |
No problem, I already fixed it and the fix just got merged. I'm just surprised it got past the autotester somehow. |
It didn't, Walter just decided to merge it manually instead of using the autotester's auto-merge. |
Ah, figures. |
This will properly set the ELF OSABI field based on the target (for ELF targets).
https://issues.dlang.org/show_bug.cgi?id=12965