Issue 13001 - Add VRP support for ternary operator ?: #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| byte b; | ||
| foreach (const i; 0..args.length?2:3) | ||
| b = i; |
There was a problem hiding this comment.
You can check the exact boundaries with b = i - 130; static assert(!__traits(compiles, b = i - 131)); and similar for upper bound. The CondExp tests should probably not be mixed in with the foreach tests, and there is no need to create a new file for this test.
Also, indentation doesn't match.
There was a problem hiding this comment.
Without foreach it will use the "Match" mechanism in the compiler and figure out that both the left and the right part of ?: can be cast to byte. I need to force it to use VRP instead.
lionello
changed the title
|
Looks good. After rebasing, I'll merge this. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Jun 29, 2014
Issue 13001 - Add VRP support for ternary operator ?:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13001