Fix #13277 - Base class in JSON output is always unqualified #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires test case fix. |
|
Woops, missed that. I'll make that change in a bit, but first a question. I noticed that originalType is also output as unqualified, and made the same change that I did here to that, yet it still is producing unqualified names as the output. json.c:478 and json.c:481 are the ones I changed to |
|
Json field Technically, |
… qualified names rather than unresolved names.
|
Alright, updated to fix the tests. |
|
LGTM. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Aug 17, 2014
Fix #13277 - Base class in JSON output is always unqualified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13277 as well as expands the names of the interfaces it implements.