Issue 3990 - Deferencing a dynamic array as pointer #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error message still says "is deprecated", should be "is (not|no longer) supported". |
| @@ -9185,7 +9185,7 @@ Expression *PtrExp::semantic(Scope *sc) | |||
|
|
|||
| case Tsarray: | |||
| case Tarray: | |||
| deprecation("using * on an array is deprecated; use *(%s).ptr instead", e1->toChars()); | |||
| error("using * on an array is deprecated; use *(%s).ptr instead", e1->toChars()); | |||
There was a problem hiding this comment.
Those brackets around the array seem superfluous. It should be *(%s.ptr).
There was a problem hiding this comment.
It could be any expression typed as an array.
Deprecation -> Error
|
Updated message. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Aug 31, 2014
Issue 3990 - Deferencing a dynamic array as pointer
|
Updating the page http://dlang.org/deprecate is also necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was deprecated almost 3 years ago.
https://issues.dlang.org/show_bug.cgi?id=3990