Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 13403 - [ICE][2.067Alpha] Internal error: backend\type.c 332 with new package protection extension. #3940

Merged
merged 1 commit into from Sep 11, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Sep 1, 2014

@mihails-strasuns
Copy link

Education question - what is addMember method here and why it needs to be used instead of semantic pass?

@9rnsr
Copy link
Contributor Author

9rnsr commented Sep 1, 2014

TemplateDeclaration::semantic calls sc->module->toModuleArray(). For that backend should be already initialized, but backend_init() is called after importAll phase (it calls module members' addMember) in mars.c.
So, ProtDeclaration::addMember and importAll should not call its members' semantic function.

@DmitryOlshansky
Copy link
Member

I confirm that this indeed unblocks my pull for std.regex:
dlang/phobos#2412

There is another bug I've yet to reduce but it was trivially workaroundable ;)

@yebblies
Copy link
Member

Auto-merge toggled on

yebblies added a commit that referenced this pull request Sep 11, 2014
Issue 13403 - [ICE][2.067Alpha] Internal error: backend\type.c 332 with new package protection extension.
@yebblies yebblies merged commit ff051c6 into dlang:master Sep 11, 2014
@9rnsr 9rnsr deleted the fix13403 branch September 13, 2014 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants