Add TemplateInstance::tnext to construct instantiation dependency graph #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnsr
force-pushed
the
fix_tinst
branch
3 times, most recently
from
2ae1fb8
to
437cfda
Compare
To detect speculative instantiations in codegen phase, `tnext` is neccesary for the `test6()` case `runnable/link13350.d`. That's a big difference from the PR dlang#2550.
WalterBright
added a commit
that referenced
this pull request
Sep 14, 2014
Add TemplateInstance::tnext to construct instantiation dependency graph
|
Thanks! |
|
This pull request introduced a regression: |
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Sep 15, 2014
…ixed in functions In the PR dlang#3948, I changed the position where `TemplateInstance`s are inserted. https://github.com/D-Programming-Language/dmd/pull/3948/files#diff-0477a1d81a6a920c99362954179c59c8R5937 But, I didn't notice that glue-layer does not handle `TemplateInstance`s in local members.
|
Another regression: https://issues.dlang.org/show_bug.cgi?id=14074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final improvement for the template instantiation model.
To detect speculative instantiations in codegen phase,
tnextis neccesary for thetest6()caserunnable/link13350.d. That's a big difference from the PR #2550.