Issue 7942 - Appending different string types corrupts memory #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -284,7 +284,7 @@ void test24() | |||
| { | |||
| wchar[] r; | |||
|
|
|||
| r ~= "\000"; | |||
| r ~= "\000"w; | |||
There was a problem hiding this comment.
Ah but wait, shouldn't we support this for literals without creating performance costs? It would be convenient.
There was a problem hiding this comment.
I guess we could... It doesn't work at the moment though.
There was a problem hiding this comment.
Ah ok then, it's better to completely disallow it then to continue doing the wrong thing. Maybe we should just file an enhancement request to avoid forgetting about it.
|
Auto-merge toggled on |
|
Thanks, I'll open an enhancement. It probably should work at least for un-suffixed strings. |
|
Thanks. |
ghost
pushed a commit
that referenced
this pull request
Sep 10, 2014
Issue 7942 - Appending different string types corrupts memory
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=7942