Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target for default dmd.conf #4098

Merged
merged 1 commit into from Nov 10, 2014
Merged

Conversation

MartinNowak
Copy link
Member

  • works for the common dmd/druntime/phobos folder layout
  • does not overwrite existing dmd.conf files

@andralex
Copy link
Member

New dir and one file per OS seems excessive. How about instead just generate the file with echo or a heredoc in the makefile.

The larger question is whether we want to use a config file there, or instead pass complete command line commands at all times. I suppose the conf file should be all right but am a bit uneasy.

@braddr
Copy link
Member

braddr commented Oct 27, 2014

also leaves us with two sets of conf files in the dmd repo.. why? What is this solving and avoiding solving by introducing the duplication?

@joakim-noah
Copy link
Contributor

A solution for the file duplication might be to generate the appropriate dmd.conf in posix.mak by replacing the paths from the conf files we already have, either by using sed or the newly compiled dmd to run a script. I used sed when I wrote the makefiles for the FreeBSD port years ago and had to modify some files from the standard zip download.

@MartinNowak
Copy link
Member Author

also leaves us with two sets of conf files in the dmd repo.. why? What is this solving and avoiding solving by introducing the duplication?

This is needed because of the different folder layout in the release zip.

@MartinNowak
Copy link
Member Author

Updated, now generates the file in the Makefile.

@MartinNowak
Copy link
Member Author

Anyone?

@quickfur
Copy link
Member

quickfur commented Nov 3, 2014

Does this work with non-gmake versions of make?

@MartinNowak
Copy link
Member Author

Does this work with non-gmake versions of make?

We're already relying on gnu make specific additions and what other make would you want to support?

@quickfur
Copy link
Member

quickfur commented Nov 6, 2014

Just checking. In that case, LGTM.

@MartinNowak
Copy link
Member Author

Anyone want's to merge this? It makes it simpler to set up a working build environment.

@WalterBright
Copy link
Member

I'm concerned about this. The current dmd looks along a set of directories for dmd.conf. This change causes posix.mak to generate one if there isn't one in the current directory, thus overriding what the user might have set.

- works for the common dmd/druntime/phobos folder layout

- does not overwrite existing dmd.conf files
@MartinNowak MartinNowak changed the title install a default dmd.conf add target for default dmd.conf Nov 8, 2014
@MartinNowak
Copy link
Member Author

I'm concerned about this. The current dmd looks along a set of directories for dmd.conf.

It's only for the development build. Anyhow, I changed it to only provide the make rule but removed it from the default target.
So you have to explicitly run make -f posix.mak dmd dmd.conf.

@yebblies
Copy link
Member

yebblies commented Nov 8, 2014

It's only for the development build. Anyhow, I changed it to only provide the make rule but removed it from the default target.

I like this better.

@WalterBright
Copy link
Member

Yes, much better.

WalterBright added a commit that referenced this pull request Nov 10, 2014
add target for default dmd.conf
@WalterBright WalterBright merged commit d1686a3 into dlang:master Nov 10, 2014
@MartinNowak MartinNowak deleted the dmdConf branch November 12, 2014 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants