New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add target for default dmd.conf #4098
Conversation
MartinNowak
commented
Oct 27, 2014
- works for the common dmd/druntime/phobos folder layout
- does not overwrite existing dmd.conf files
New dir and one file per OS seems excessive. How about instead just generate the file with The larger question is whether we want to use a config file there, or instead pass complete command line commands at all times. I suppose the conf file should be all right but am a bit uneasy. |
also leaves us with two sets of conf files in the dmd repo.. why? What is this solving and avoiding solving by introducing the duplication? |
A solution for the file duplication might be to generate the appropriate dmd.conf in posix.mak by replacing the paths from the conf files we already have, either by using sed or the newly compiled dmd to run a script. I used sed when I wrote the makefiles for the FreeBSD port years ago and had to modify some files from the standard zip download. |
This is needed because of the different folder layout in the release zip. |
Updated, now generates the file in the Makefile. |
Anyone? |
Does this work with non-gmake versions of make? |
We're already relying on gnu make specific additions and what other make would you want to support? |
Just checking. In that case, LGTM. |
Anyone want's to merge this? It makes it simpler to set up a working build environment. |
I'm concerned about this. The current dmd looks along a set of directories for dmd.conf. This change causes posix.mak to generate one if there isn't one in the current directory, thus overriding what the user might have set. |
- works for the common dmd/druntime/phobos folder layout - does not overwrite existing dmd.conf files
It's only for the development build. Anyhow, I changed it to only provide the make rule but removed it from the default target. |
I like this better. |
Yes, much better. |
add target for default dmd.conf