Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 13907 - Surrogate pairs in wchar string literal will cause incorrect length match #4222

Merged
merged 3 commits into from Dec 31, 2014
Merged

Issue 13907 - Surrogate pairs in wchar string literal will cause incorrect length match #4222

merged 3 commits into from Dec 31, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Dec 29, 2014

@9rnsr
Improve StringExp::length() to support transcoding
eec3d9e
@9rnsr
Handle extending string literal length to the target static array type
f606bd4 
Both expression initializers and struct literal arguments should support implicit string lengthen.
@9rnsr
fix Issue 13907 - Surrogate pairs in wchar string literal will cause …
6d73218 
…incorrect length match

Stop considering lengthen conversion in StringExp::implicitConvTo().
WalterBright added a commit that referenced this pull request Dec 31, 2014
@WalterBright
Merge pull request #4222 from 9rnsr/fix13907
4e21e56 
Issue 13907 - Surrogate pairs in wchar string literal will cause incorrect length match
@WalterBright WalterBright merged commit 4e21e56 into dlang:master Dec 31, 2014
@9rnsr 9rnsr deleted the fix13907 branch December 31, 2014 12:26
@schuetzm
Copy link
Contributor

Here's a test case:

void main() {
        string[2][] test;
        test ~= "";
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@9rnsr @schuetzm @adamdruppe @WalterBright