Issue 13485 - FP wrong-code with -O #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I hope this PR unblock dlang/phobos#2513. |
| @@ -214,6 +214,7 @@ STATIC void local_exp(elem *e,int goal) | |||
| em->E1->EV.sp.Vsym == s && | |||
| tysize(em->Ety) == tysize(e1->Ety) && | |||
| em->E1->EV.sp.Voffset == e1->EV.sp.Voffset && | |||
| (config.flags4 & CFG4fastfloat || !tyfloating(em->Ety)) && | |||
There was a problem hiding this comment.
extra parens for clarity?
((config.flags4 & CFG4fastfloat) || !tyfloating(em->Ety)) &&
There was a problem hiding this comment.
The backend's style is no parens.
|
Documentation on fastfloat: http://www.digitalmars.com/ctg/sc.html#dashff No, I don't think it applies. I'd just remove the check for it from the patch. |
|
Updated. |
WalterBright
added a commit
that referenced
this pull request
Feb 14, 2015
Issue 13485 - FP wrong-code with -O
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting
x += a; x += btox += a + b;is not valid with floating point types in D.I'm assuming it is valid with fastfloat enabled, @WalterBright ?
https://issues.dlang.org/show_bug.cgi?id=13485