Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG2.066] Issue 14424 - dmd crashes with __traits(getUnitTests) #4593

Merged
merged 1 commit into from Apr 18, 2015

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Apr 18, 2015

https://issues.dlang.org/show_bug.cgi?id=14424

It was necessary to avoid excessive semantic3 with -unittest -inline (see commit 474e0d2), but today compiler incrementally runs semantic3 of the candidate functions for inlining (see commit df11f21). Therefore the hack is not necessary anymore.

It was necessary to avoid excessive semantic3 with -unittest -inline (see commit 474e0d2), but today compiler incrementally runs semantic3 of the candidate functions for inlining (see commit df11f21). Therefore the hack is not necessary anymore.
@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 18, 2015

Ready to merge .

@andralex
Copy link
Member

Love the red. Thanks, Kenji!

@andralex
Copy link
Member

Auto-merge toggled on

andralex added a commit that referenced this pull request Apr 18, 2015
[REG2.066] Issue 14424 - dmd crashes with __traits(getUnitTests)
@andralex andralex merged commit 5f2bfa0 into dlang:master Apr 18, 2015
@MartinNowak
Copy link
Member

Thanks, same here, please use stable instead of master, we want to get rid of cherry-picking.

MartinNowak added a commit that referenced this pull request Apr 18, 2015
[REG2.066] Issue 14424 - dmd crashes with __traits(getUnitTests)
Conflicts:
	src/func.c
@9rnsr 9rnsr deleted the fix14424 branch April 18, 2015 23:27
tramker added a commit to tramker/dmd that referenced this pull request May 25, 2015
[REG2.066] Issue 14424 - dmd crashes with __traits(getUnitTests)
Conflicts:
	src/func.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants