Issue 3841: silent implicit cast from floating point to integral in += etc. operators #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrosbuffle
force-pushed
the
fix3841
branch
2 times, most recently
from
e58ccfe
to
b29f8f0
Compare
|
The large function being moved from one place to another in the file makes it very, very difficult to review. |
|
I've un-moved the function |
| { | ||
| if ((type->isintegral() && t2->isfloating())) | ||
| { | ||
| error("%s %s %s is undefined (refusing to perform truncating conversion)", |
There was a problem hiding this comment.
This should be made a warning, because it will force people to change their code. The idea is warning, then deprecation, then finally error, after some major time has elapsed.
|
Thanks for undoing the code movement. Now I can see what changed! |
legrosbuffle
force-pushed
the
fix3841
branch
3 times, most recently
from
de2b848
to
01b3f92
Compare
| // pragma(msg, LHS, " += ", RHS); | ||
| LHS a; | ||
| RHS b; | ||
| a += b; |
There was a problem hiding this comment.
This is good, but also need to test -=, *=, /=, %= and ^^=
|
thx!! please add the extra tests |
|
Done, thanks for the review. |
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
May 19, 2015
Issue 3841: silent implicit cast from floating point to integral in += etc. operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this might break some existing code that relies on bad behaviour, but I think it's important to fix. For example, there are three such instances in phobos, and one of them is obviously bogus:
int chunksize, extra, numchunks;
...
chunksize += extra / cast(double)numchunks;
(I'll send a pull request to phobos)