Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 14571 - [REG2.064] Large static arrays seem to lock up DMD #4673

Merged
merged 1 commit into from May 24, 2015

Conversation

WalterBright
Copy link
Member

/**************************************
* Repeat a list of dt_t's len times.
*/
dt_t **dtrepeat(dt_t **pdtend, dt_t *dt, size_t len)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call the parameter num or something instead of len? I know you're using it for static arrays, as this function isn't specific to them I think len isn't a great fit.

@WalterBright WalterBright added the Regression PRs that fix regressions label May 23, 2015
@9rnsr
Copy link
Contributor

9rnsr commented May 24, 2015

Auto-merge toggled on

@yebblies
Copy link
Member

I didn't realise this had been updated, all looks good.

9rnsr added a commit that referenced this pull request May 24, 2015
fix Issue 14571 - [REG2.064] Large static arrays seem to lock up DMD
@9rnsr 9rnsr merged commit bb7b196 into dlang:master May 24, 2015
tramker added a commit to tramker/dmd that referenced this pull request May 25, 2015
fix Issue 14571 - [REG2.064] Large static arrays seem to lock up DMD
Conflicts:
	src/todt.c
@WalterBright WalterBright deleted the fix14571 branch May 25, 2015 18:46
@ibuclaw
Copy link
Member

ibuclaw commented May 30, 2015

Years ago when I removed all dt_* symbols inherited from dmd and did a clean-room reimplementation of toDt, I did initially use a linked list to push in all static data. Needless to say performance dropped so bad that I quickly switched to a vector (dynamic array) and have never look back since!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression PRs that fix regressions
Projects
None yet
4 participants