Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDMD: Fix duplicate definition linker errors in gdc #4676

Merged
merged 1 commit into from Aug 23, 2015

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 23, 2015

As per discussion, dmd does some fancy section trick to evade this. But it just won't fly in gdc.

@klickverbot - would this bug you?

@ibuclaw ibuclaw added DDMD GDC Gnu D Compiler labels May 23, 2015
@yebblies
Copy link
Member

You should probably make up a new version for these and set it from the command line, eg version=OverrideAllocationFunctions. Host compiler conditions really don't belong in here.

@MartinNowak
Copy link
Member

It also doesn't work with LDC b/c only dmd creates multilibs.

@MartinNowak
Copy link
Member

We should make a GC proxy to override the allocations. Simply disabling them for GDC/LDC is a major slowdown.

@yebblies
Copy link
Member

We should make a GC proxy to override the allocations. Simply disabling them for GDC/LDC is a major slowdown.

That's outside my expertise. How complicated is it?

@dnadlinger
Copy link
Member

We should make a GC proxy to override the allocations. Simply disabling them for GDC/LDC is a major slowdown.

In the preliminary tests we did after DConf, it did not seem to make much of a difference. But yeah, we should look into such optimizations after the merge.

@MartinNowak
Copy link
Member

Let's deactivate the stuff for now.

MartinNowak added a commit that referenced this pull request Aug 23, 2015
DDMD: Fix duplicate definition linker errors in gdc
@MartinNowak MartinNowak merged commit bcfad59 into dlang:master Aug 23, 2015
@ibuclaw ibuclaw deleted the druntime branch August 23, 2015 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDC Gnu D Compiler
Projects
None yet
4 participants