[REG2.068a] Issue 14844 - __traits(allMembers) must not visit yet not instantiated template members #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| e->error("%s %s has no members", s->kind(), s->toChars()); | ||
| goto Lfalse; | ||
| return new ErrorExp(); |
There was a problem hiding this comment.
Why did you introduce the ErrorExp, seems unrelated and is inconsistent with the goto Lfalse above.
There was a problem hiding this comment.
It was just for the redundant error message. I think if any errors happen in semanticTraits, it should return ErrorExp. But it's not important point of this PR, so I tweaked test case, and then changed to use goto Lfalse in here.
|
Rest LGTM. |
…iated template members
WalterBright
added a commit
that referenced
this pull request
Jul 30, 2015
[REG2.068a] Issue 14844 - __traits(allMembers) must not visit yet not instantiated template members
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14844