Issue 14846 - Insufficient context deduction with implicit nested lambda #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,8 @@ bool checkFrameAccess(Loc loc, Scope *sc, AggregateDeclaration *ad, size_t iStar | |||
| { | |||
| if (!fd->isThis() && !fd->isNested()) | |||
| break; | |||
| if (FuncLiteralDeclaration *fld = fd->isFuncLiteralDeclaration()) | |||
| fld->tok = TOKdelegate; | |||
There was a problem hiding this comment.
checkFrameAccess is supposed to be a pure function, merely checking things. But here it is now modifying global state. There's got to be a better way. I do note that checkNestedReference does it, too, so there's an excuse for it. I hope that when we switch to ddmd, we can migrate to a better design.
There was a problem hiding this comment.
Or, the problem is in the function name - checkSomething VS checkAndFixSomething.
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Aug 7, 2015
Issue 14846 - Insufficient context deduction with implicit nested lambda
|
Thanks. |
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 8, 2015
Issue 14846 - Insufficient context deduction with implicit nested lambda
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 10, 2015
Issue 14846 - Insufficient context deduction with implicit nested lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14846
Requires Phobos tweak: dlang/phobos#3519