Issue 14459 - String literal merge bug causes incorrect runtime program behavior #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is e2` By this additional translation, we can have only one semantic analysis result for the equivalent expression forms.
|
Also, I found a small AST ambiguity between EqualExp and IdentityExp for pointer comparisons. |
|
Auto-merge toggled on |
dnadlinger
added a commit
that referenced
this pull request
Aug 6, 2015
Issue 14459 - String literal merge bug causes incorrect runtime program behavior
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 7, 2015
Issue 14459 - String literal merge bug causes incorrect runtime program behavior
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 10, 2015
Issue 14459 - String literal merge bug causes incorrect runtime program behavior
|
This PR caused a regression: https://issues.dlang.org/show_bug.cgi?id=20758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14459
The excessive value expansion in
optimize.chad corrupted the result of pointer identity comparison.